Skip to content

test(desktop): cover new-session model selection regression - #4014

Open
MsNBBc3R wants to merge 1 commit into
makecindy:mainfrom
MsNBBc3R:fix/issue-4003-new-session-model-switch
Open

test(desktop): cover new-session model selection regression#4014
MsNBBc3R wants to merge 1 commit into
makecindy:mainfrom
MsNBBc3R:fix/issue-4003-new-session-model-switch

Conversation

@MsNBBc3R

@MsNBBc3R MsNBBc3R commented Sep 6, 2026

Copy link
Copy Markdown

Summary

  • add regression coverage for model selection in a new conversation
  • ensure the draft path does not call the existing-session maker.setModel flow
  • ensure context-window switching guards are not entered before the first message

Validation

  • chatInputModelSelectorRouting.test.ts
  • newMakerProjectPicker.test.ts
  • unifiedModelPanelRendering.test.tsx
  • Desktop TypeScript typecheck

@MsNBBc3R
MsNBBc3R requested a review from a team as a code owner September 6, 2026 14:37
@greptile-apps

greptile-apps Bot commented Sep 6, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds regression coverage for new-conversation model selection in the desktop renderer.

  • Confirms draft model selection routes through handleUnifiedDraftSelect.
  • Confirms the draft path does not invoke existing-session model mutation or context-window guards.
  • Changes tests only; production behavior is unaffected.

Confidence Score: 5/5

The PR appears safe to merge because it only adds focused regression coverage and introduces no actionable defects.

The added assertions align with the documented transient new-session draft flow and correctly distinguish it from existing-session model switching.

Important Files Changed

Filename Overview
apps/desktop/src/renderer/tests/chatInputModelSelectorRouting.test.ts Adds focused source-contract assertions that preserve draft-only model selection before a session exists.

Reviews (1): Last reviewed commit: "test(desktop): cover new-session model s..." | Re-trigger Greptile

@MagicLizi MagicLizi added the status:ci-running CI 还在跑(review-pr 自动维护,仅展示) label Sep 6, 2026
Signed-off-by: MsNBBc3R <MsNBBc3R@users.noreply.github.com>
@MsNBBc3R
MsNBBc3R force-pushed the fix/issue-4003-new-session-model-switch branch from 39dbce1 to 3912b46 Compare September 6, 2026 15:49
@MagicLizi MagicLizi added status:ci-failed CI 失败(review-pr 自动维护,仅展示) status:ci-running CI 还在跑(review-pr 自动维护,仅展示) and removed status:ci-running CI 还在跑(review-pr 自动维护,仅展示) status:ci-failed CI 失败(review-pr 自动维护,仅展示) labels Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:ci-failed CI 失败(review-pr 自动维护,仅展示)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants