Repository navigation
Make finnpower-counter an installable package (0.2.0) - #5
Open
malinkin-s wants to merge 1 commit into
Open
malinkin-s wants to merge 1 commit into
malinkin-s wants to merge 1 commit into
Conversation
Nestrack will reuse the parser instead of copying it, so the utility now installs with pip and its parser imports without a GUI (tasks P-01, P-02). - pyproject.toml: setuptools build, no runtime dependencies, version read from finnpower_counter.__version__, `finnpower-counter` and `finnpower-counter-gui` commands. - Version 0.2.0 and CHANGELOG.md: the first release meant to be tagged, covering the audit fixes from #2. - tests/test_packaging.py: core and presentation must import nothing from tkinter, socket, ssl, http or urllib (checked in a separate process). - CI: build the wheel, install it into a clean venv and run it from outside the source tree, on Windows/Python 3.8 x86 and Linux/Python 3.13. - README: installing as a package. - FINDINGS/TASKS: BrokenPipeError in the CLI treated as a crash (FND-19, M-12), found while testing the package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CW3WfPRekjK4x6M8VNRckz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks P-01 and P-02: Nestrack will reuse this parser as a pinned package instead of copying it.
Changes
pyproject.toml— setuptools build, no runtime dependencies, version read fromfinnpower_counter.__version__, commandsfinnpower-counterandfinnpower-counter-gui. The license stays in the table form: the SPDX string needs setuptools ≥ 77, which no longer runs on Python 3.8.CHANGELOG.md— the first release meant to be tagged; it covers the audit fixes from Исправления по аудиту: обезличивание отчёта, нечитаемые файлы, CI #2.tests/test_packaging.py—coreandpresentationmust import nothing fromtkinter,socket,ssl,http,urllib; checked in a separate process. Verified that it fails whenimport socketis added topresentation.py.headraisesBrokenPipeError, which is treated as a crash and writes an error report. Found while testing the package; not fixed here.Verified locally
finnpower_counter.coreimports without Tk; the CLI runs on theshift_okfixture.After merge
P-01 is complete once
v0.2.0is tagged onmain; the install command in the README points at that tag.🤖 Generated with Claude Code
https://claude.ai/code/session_01CW3WfPRekjK4x6M8VNRckz
Generated by Claude Code