Skip to content

feat: create new environment using a remote mamba solver#141

Open
mariobuikhuizen wants to merge 15 commits intomamba-org:mainfrom
mariobuikhuizen:mamba_hint_solve
Open

feat: create new environment using a remote mamba solver#141
mariobuikhuizen wants to merge 15 commits intomamba-org:mainfrom
mariobuikhuizen:mamba_hint_solve

Conversation

@mariobuikhuizen
Copy link
Copy Markdown

Point quetz_url and quetz_solve_url in packages/common/src/components/CondaHints.ts to your Quetz server/solver.

On the Quetz server with the solver add:

[cors]
allow_origins=["*", "http://localhost"]

to config.toml

The code completion in the environment editor can be activated with CTRL-space.

@github-actions
Copy link
Copy Markdown

Binder 👈 Launch a binder notebook on the branch mariobuikhuizen/gator/mamba_hint_solve

The code completion in the environment editor can be activated
with CTRL-space.
@mariobuikhuizen
Copy link
Copy Markdown
Author

gator1.mp4

@fcollonval
Copy link
Copy Markdown
Member

Thanks a lot for this awesome feature @mariobuikhuizen

I'll try to review it in the coming days.

One design question from the demo (thanks for it); did you think about various design? For example, does it make sense to open a new mainwidgetarea containing the editor with the button as toolbar button? The idea would be to create/edit environment file in a standalone widget directly from the filebrowser in addition to the demo you are presenting.

@mariobuikhuizen
Copy link
Copy Markdown
Author

That sounds like a good idea @fcollonval, I'll look into that.

@mariobuikhuizen
Copy link
Copy Markdown
Author

Thanks @hbcarlos!

Copy link
Copy Markdown
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for this awesome feature. I left some comments; mainly I think the code could be simplified by reusing the import feature directly. And I'm worry that fetching the quetz server should be proxied through the server extension instead of being done on the frontend to avoid CORS errors.

Comment thread mamba_gator/envmanager.py Outdated
Comment thread mamba_gator/handlers.py Outdated
Comment thread packages/common/src/components/CondaHint.ts
Comment thread packages/common/src/components/CondaHint.ts Outdated
Comment thread packages/common/src/components/CondaHint.ts Outdated
Comment thread packages/common/src/components/NbConda.tsx Outdated
Comment thread packages/common/src/components/CondaHint.ts
Comment thread packages/common/src/services.ts Outdated
Comment thread mamba_gator/handlers.py Outdated
Comment thread setup.py Outdated
@fcollonval fcollonval self-requested a review June 17, 2021 12:37
Copy link
Copy Markdown
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mariobuikhuizen I added some comments.

Comment thread mamba_gator/navigator/main.py Outdated
Comment thread packages/common/src/components/CondaEnvSolve.tsx
Comment thread packages/common/src/components/CondaEnvSolve.tsx
Comment thread packages/common/src/components/CondaEnvSolve.tsx
Comment thread packages/common/src/components/CondaEnvSolve.tsx Outdated
Comment thread mamba_gator/navigator/main.py Outdated
Comment thread packages/common/src/tokens.ts
Comment thread packages/labextension/schema/plugin.json Outdated
Comment thread packages/labextension/src/CondaCompleteEditor.tsx
Comment thread packages/labextension/src/CondaCompleteEditor.tsx Outdated
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
@mariobuikhuizen
Copy link
Copy Markdown
Author

I discovered an issue with setting arguments with the standalone navigator with jupyter_server 1.9 (in 1.6.1 it works). Taking a look at that now.

@mariobuikhuizen
Copy link
Copy Markdown
Author

I think it's an issue in jupyter-server: jupyter-server/jupyter_server#550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants