Remove is_mamba() check to support conda-libmamba-solver for repoquery command#381
Draft
RRosio wants to merge 3 commits intomamba-org:mainfrom
Draft
Remove is_mamba() check to support conda-libmamba-solver for repoquery command#381RRosio wants to merge 3 commits intomamba-org:mainfrom
is_mamba() check to support conda-libmamba-solver for repoquery command#381RRosio wants to merge 3 commits intomamba-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the dependency query and package listing logic in
EnvManager, improves fallback handling whenrepoqueryis unavailable, and modernizes related tests.Backend improvements and fallback logic:
pkg_dependsandlist_availablemethods inEnvManagerto handle cases whererepoqueryis unavailable or fails, providing warnings and falling back toconda searchas needed.list_availableto check the return code fromrepoqueryand only process results if successful.Testing improvements:
test_api.pyto simulate and assert correct behavior whenrepoqueryis unavailable, including proper use of fallbacks and correct command invocationtest_manager.pyto verify thatlist_availablecorrectly falls back toconda searchwhenrepoqueryfails.User interface improvement:
PkgGraphReact component to clarify that dependency queries require eitherconda-libmamba-solverormamba, and provided a more relevant help link.