Add telescope+libretls port#196
Conversation
| -int safe_mode; | ||
| +int safe_mode = 0; |
There was a problem hiding this comment.
This shouldn't do anything since global vars are initialized to zero anyway.
| environ: | ||
| DESTDIR: '@THIS_COLLECT_DIR@' | ||
|
|
||
| - name: libretls |
There was a problem hiding this comment.
This port lacks meta data. Is it necessary to use this package? We already have OpenSSL.
There was a problem hiding this comment.
libretls is a libtls reimplementation of libtls for openssl
There was a problem hiding this comment.
Aside from missing metadata and architecture labels, ports should have one empty line between them. And yes, we need libretls or make telescope link against libressl, which I'm against. Gentoo has libretls in their repo's too, so this is fine.
| - while ((ch = getopt_long(argc, argv, opts, longopts, NULL)) != -1) { | ||
| + optind = 0; | ||
| + while ((ch = getopt(argc, argv, opts)) != -1) { |
There was a problem hiding this comment.
Working around unimplemented/incorrectly implemented functionality in getopt_long. The optind = 0 can be dropped, though.
There was a problem hiding this comment.
Then getopt_long should be fixed instead of hacking around such issues here.
| - if (socketpair(AF_UNIX, SOCK_STREAM, PF_UNSPEC, pipe2net) == -1) | ||
| + if (socketpair(AF_UNIX, SOCK_STREAM, 0, pipe2net) == -1) |
There was a problem hiding this comment.
Why is this done? If we're missing PF_UNSPEC, adding it to mlibc should be simple.
There was a problem hiding this comment.
We have it, however Managarm code asserts that the protocol (3rd argument) is 0. We should change the Managarm code to allow PF_UNSPEC (which is basically pick what you think is best afaik).
There was a problem hiding this comment.
upstream is wrong here afaik, from posix:
protocol Specifies a particular protocol to be used with the socket. Specifying a protocol of 0 causes socket() to use an unspecified default
protocol appropriate for the requested socket type.
Dennisbonke
left a comment
Dennisbonke
left a comment
There was a problem hiding this comment.
For a first attempt this is quite decent, I've added my comments that others hadn't made yet.
| environ: | ||
| DESTDIR: '@THIS_COLLECT_DIR@' | ||
|
|
||
| - name: libretls |
There was a problem hiding this comment.
Aside from missing metadata and architecture labels, ports should have one empty line between them. And yes, we need libretls or make telescope link against libressl, which I'm against. Gentoo has libretls in their repo's too, so this is fine.
| - args: ['make', '-j@PARALLELISM@'] | ||
| - args: ['make', 'install'] | ||
| environ: | ||
| DESTDIR: '@THIS_COLLECT_DIR@' |
There was a problem hiding this comment.
Same here, newline after a port recipe.
| configure: | ||
| - args: | ||
| - '@THIS_SOURCE_DIR@/configure' | ||
| - '--host=x86_64-managarm' |
There was a problem hiding this comment.
We should use - '--host=@OPTION:arch-triple@' instead of hardcoding architectures here.
| - args: ['make', 'DESTDIR=@THIS_COLLECT_DIR@', 'install'] | ||
| environ: | ||
| DESTDIR: '@THIS_COLLECT_DIR@' | ||
| - name: telescope |
There was a problem hiding this comment.
Same here, a newline should be added between ports.
|
Gonna hold of on this until the various mlibc things are merged |
5 participants
No description provided.