Skip to content

Add snappy, libx264, opus, libvpx, ffmpeg, lcms, re2#211

Open
Dennisbonke wants to merge 7 commits into
managarm:masterfrom
Dennisbonke:yes-i-have-even-more-ports
Open

Add snappy, libx264, opus, libvpx, ffmpeg, lcms, re2#211
Dennisbonke wants to merge 7 commits into
managarm:masterfrom
Dennisbonke:yes-i-have-even-more-ports

Conversation

@Dennisbonke
Copy link
Copy Markdown
Member

All of these ports are split off from #178, and as far as I can tell should just be good to go.

The following ports have been added:

  • snappy;
  • libx264;
  • opus;
  • libvpx;
  • ffmpeg;
  • lcms;
  • re2.

Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
@Dennisbonke Dennisbonke force-pushed the yes-i-have-even-more-ports branch from 91ac652 to 53a39c3 Compare October 8, 2022 11:02
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
@Dennisbonke Dennisbonke force-pushed the yes-i-have-even-more-ports branch from 53a39c3 to 6ebd5eb Compare October 8, 2022 11:15
@avdgrinten avdgrinten changed the title Add several ports I had laying around Add snappy, libx264, opus, libvpx, ffmpeg, lcms, re2 Oct 9, 2022
- '--arch=@OPTION:arch@'
- '--cross-prefix=@OPTION:arch-triple@'
- '--host-cc=gcc'
- '--target-os=linux' # Fun times ahead
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we add a target for Managarm?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably me being lazy and it seems to work out fine, so no need to add extra patchwork that needs to be upstreamed eventually.

Comment on lines +19 to +20
-#if HAVE_SCHED_GETAFFINITY && defined(CPU_COUNT)
+#if HAVE_SCHED_GETAFFINITY && defined(CPU_COUNT) && !defined(__managarm__)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this done?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't implement this yet (or at least we didn't at the time of me porting ffmpeg).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mlibc has it stubbed, but managarm currently does not implement this. This would have to be implemented as a new hel call IIRC.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the required infrastructure to mlibc (if it doesn't exist already) and make the Managarm sysdeps return ENOSYS (and log a message).

Comment on lines +19 to +20
-#if HAVE_SCHED_GETAFFINITY && defined(CPU_COUNT)
+#if HAVE_SCHED_GETAFFINITY && defined(CPU_COUNT) && !defined(__managarm__)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mlibc has it stubbed, but managarm currently does not implement this. This would have to be implemented as a new hel call IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants