libfuse (WIP)#257
Conversation
Dennisbonke
left a comment
Dennisbonke
left a comment
There was a problem hiding this comment.
I found some issues, nothing too major but as is this would break xbbs.
| - args: ['@THIS_SOURCE_DIR@/echfs-fuse/bootstrap'] | ||
|
|
||
| packages: | ||
| - name: libfuse |
There was a problem hiding this comment.
Missing the architecture field and missing metadata.
There was a problem hiding this comment.
as far as I'm aware, echfs does not depend on a specific CPU architecture
There was a problem hiding this comment.
I understand the confusion, but that's not what the architecture field is for. Xbbs needs to know what architecture the package is for in order to put it in the correct repository. That's nearly always just the OPTION:arch substitution but sometimes it's noarch (only data files for example). Labels then control if xbbs will attempt to build the package on a specific architecture, amd64 is always implied. For now, don't add a label, but do add that architecture field, as xbbs will choke on the fact that it's not there.
| - name: echfs | ||
| subdir: 'ports' | ||
| git: 'https://github.com/echfs/echfs.git' | ||
| branch: 'master' |
There was a problem hiding this comment.
Please pin a commit and add a version field.
There was a problem hiding this comment.
I have pinned a commit; however, there does not seem to be any version noted in the repository. Do I make one up or can this field be omitted?
There was a problem hiding this comment.
Make one up in that case. Never omit a version field.
There was a problem hiding this comment.
I've made up my own for ca-certificates for example, it includes the date I pulled the data from. Just an example.
| - mlibc | ||
| configure: | ||
| - args: | ||
| - 'meson' |
There was a problem hiding this comment.
Just using meson seems to be deprecated. Meson recommends using meson setup. Please do so.
| environ: | ||
| DESTDIR: '@THIS_COLLECT_DIR@' | ||
|
|
||
| - name: echfs-utils |
There was a problem hiding this comment.
Missing architecture field and missing metadata.
There was a problem hiding this comment.
I have added an architecture field; what other metadata was missing?
There was a problem hiding this comment.
You've received a reply from Leo on discord about it but for the record, everything under the metadata tag, as seen in various packages throughout the source.
| environ: | ||
| DESTDIR: '@THIS_COLLECT_DIR@' | ||
|
|
||
| - name: echfs-fuse |
There was a problem hiding this comment.
Missing architecture field and missing metadata.
ikbenlike
force-pushed
the
libfuse
branch
2 times, most recently
from
4d8bf4f to
a6f89f2
Compare
2 participants
This PR ports libfuse3 and echfs to managarm. It depends on managarm#533 and mlibc#891.