string: deduplicate comparison logic between string and string_view#53
Open
qookei wants to merge 1 commit into
Open
string: deduplicate comparison logic between string and string_view#53qookei wants to merge 1 commit into
qookei wants to merge 1 commit into
Conversation
Member
|
What do you think of implementing the spaceship operator? |
Member
Author
|
IIRC that needs the standard comparison result types which we don't have in
cxxshim yet (I think they are a part of some PR though).
…On Sun, Oct 30, 2022, 07:08 Arsenović Arsen ***@***.***> wrote:
What do you think of implementing the spaceship operator?
—
Reply to this email directly, view it on GitHub
<#53 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AL7W6N7P24SGOFJKQZDA47TWFX7DPANCNFSM6AAAAAARR7QMBQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
ArsenArsen
approved these changes
Oct 31, 2022
Member
ArsenArsen
left a comment
ArsenArsen
left a comment
There was a problem hiding this comment.
will be okay with the spaceship added (and that was agreed upon), approving ahead of november
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36.