fix(explorer): clearer settings-row standard annotation + active-standard first#72
Merged
Merged
Conversation
- Reword the setting-frame annotations "(Birss standard)"/"(ITC standard)" to "(standard frame in Birss)"/"(standard frame in ITC)" -- they name which physical frame each convention tabulates as standard, not the symbol's notation (the names already follow the active convention). - List the active convention's standard frame first, so the first setting always matches the popup title. Non-affected groups are unchanged (order 1..N, no annotations). Display wording/ordering only; no computed-output change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the Explorer’s Operations modal “Settings” row to improve clarity around which physical frame is considered standard under Birss vs ITC, and to present the active convention’s standard frame first so the first listed setting matches the popup title.
Changes:
- Reorders the displayed setting labels so the active convention’s standard setting is shown first (while keeping the remaining settings in numeric order).
- Renames the standard annotations to “(standard frame in Birss)” / “(standard frame in ITC)” to avoid confusion with symbol notation.
- Adds an Unreleased changelog entry describing the display-only behavior change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/OperationsModal.tsx | Reorders settings display and clarifies standard-frame annotations in the modal UI. |
| CHANGELOG.md | Documents the Explorer popup settings-row wording/ordering change under Unreleased. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Display wording/ordering only (no computed-output change) in the Explorer popup's Settings row.
(Birss standard)→(standard frame in Birss),(ITC standard)→(standard frame in ITC). The setting names already follow the active convention's reading; the annotation names which physical frame each convention tabulates as the group's standard. "(Birss standard)" read too easily as "this is the Birss name".Verification (headless, driving the running app)
6'mm'Birss:6'mm' (standard frame in Birss) · 6'm'm (standard frame in ITC)6'mm'ITC:6'mm' (standard frame in ITC) · 6'm'm (standard frame in Birss)— active standard first, matches title.-42m(non-affected multi-setting), both modes:4̄2m · 4̄m2— order 1..N, no annotations, unchanged.Gates
npm run lint(tsc) — cleannpm run test— 1626 passednpm run build— succeedsBase:
5506296.🤖 Generated with Claude Code