fix(explorer): merge duplicate standard-frame annotation (6'/mm'm)#73
Merged
Conversation
…coincide For the one group whose standard frame is the same in both conventions (6'/mm'm), the settings row rendered two consecutive annotations. Show a single "(standard frame in Birss and ITC)" when birssStandard === itcStandard; otherwise unchanged (6'mm' still shows the two separate annotations). Display wording only; no computed-output change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Explorer’s Operations modal settings-row annotations to avoid showing duplicate “standard frame” labels when Birss and ITC share the same standard-frame setting for a group.
Changes:
- Merge duplicate standard-frame annotations into a single “(standard frame in Birss and ITC)” label when
birssStandard === itcStandard. - Update the changelog entry to document the merged-annotation behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/OperationsModal.tsx | Conditionally renders a single merged standard-frame annotation when Birss/ITC standards match. |
| CHANGELOG.md | Documents the new merged-annotation wording in the Explorer popup settings row. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
172
to
183
| {conventionAffected && birssStandard === itcStandard && setting === birssStandard ? ( | ||
| <span className="text-xs text-ink/50">(standard frame in Birss and ITC)</span> | ||
| ) : ( | ||
| <> | ||
| {conventionAffected && setting === birssStandard && ( | ||
| <span className="text-xs text-ink/50">(standard frame in Birss)</span> | ||
| )} | ||
| {conventionAffected && setting === itcStandard && ( | ||
| <span className="text-xs text-ink/50">(standard frame in ITC)</span> | ||
| )} | ||
| </> | ||
| )} |
Owner
Author
There was a problem hiding this comment.
Fixed in 7ec51a8 — hoisted the conventionAffected check to gate the whole block once; no empty fragment or repeated check. Behaviour unchanged.
Address Copilot review: hoist the conventionAffected check to gate the whole annotation block instead of re-checking it in each branch (no empty fragment when not convention-affected). Behaviour unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Display wording only. For the single group whose standard frame is the same in both conventions (
6'/mm'm,STANDARD_STAYS_AT_SETTING_1), the settings row rendered two consecutive annotations(standard frame in Birss) (standard frame in ITC). WhenbirssStandard === itcStandard, it now renders one span(standard frame in Birss and ITC); otherwise unchanged.Verification (headless, driving the running app)
6'/mm'm— Birss and ITC modes: single merged(standard frame in Birss and ITC).6'mm'— ITC: still two separate annotations (6'mm'→ standard frame in ITC,6'm'm→ standard frame in Birss).Gates
npm run lint(tsc) — cleannpm run test— 1626 passednpm run build— succeedsBase:
9a90082.🤖 Generated with Claude Code