π‘οΈ Sentinel: [CRITICAL] Fix SQL injection in SQLite PRAGMA configuration#104
Conversation
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: The SQLite observability store directly interpolates the
MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODEenvironment variable into aPRAGMAstatement using string concatenation. SincePRAGMAqueries in SQLite do not support parameterized variables (?), this exposes the system to SQL injection attacks if a malicious configuration is provided.π― Impact: A maliciously configured environment variable could execute arbitrary SQL commands during the database connection phase, leading to potential data destruction or unauthorized data manipulation in the observability logs.
π§ Fix: Added a strict allowlist validation for
configured_journal_mode. If the environment variable provides a mode that isn't one of the known safe operations (e.g.,WAL,DELETE,OFF), it safely falls back to the defaultWAL.β Verification: Verified the change by testing an unsafe environment injection and ensuring it defaults to
WAL, and confirmed via local tests that regressions weren't introduced.PR created automatically by Jules for task 1854527127887819927 started by @mapleleaflatte03