π‘οΈ Sentinel: [CRITICAL] Fix PRAGMA SQL injection vulnerability#110
π‘οΈ Sentinel: [CRITICAL] Fix PRAGMA SQL injection vulnerability#110mapleleaflatte03 wants to merge 2 commits into
Conversation
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
π¨ Severity: CRITICAL
π‘ Vulnerability: Unvalidated environment variable (
MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODE) is used to directly format a SQLitePRAGMAstatement, leading to a SQL injection vulnerability.π― Impact: A malicious user or compromised environment could inject arbitrary SQLite commands, leading to data deletion or database corruption.
π§ Fix: Validated the environment variable against a strict allowlist of known-good SQLite journal modes (
'DELETE','TRUNCATE','PERSIST','MEMORY','WAL','OFF','DEFAULT') before executing thePRAGMAstatement, and fell back to the safe default ('WAL') if validation fails.β Verification: Ran
python3 -m unittest discoveron the observability platform tests. Confirmed that no new errors were introduced by the stricter journal mode parsing.PR created automatically by Jules for task 9905149795299783722 started by @mapleleaflatte03