π‘οΈ Sentinel: [HIGH] Fix SQL injection risk in SQLite PRAGMA execution#114
π‘οΈ Sentinel: [HIGH] Fix SQL injection risk in SQLite PRAGMA execution#114mapleleaflatte03 wants to merge 2 commits into
Conversation
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
β¦solution Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
π¨ Severity: HIGH
π‘ Vulnerability: The
MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODEenvironment variable was directly concatenated into an SQLitePRAGMA journal_modecommand using an f-string inintelligence/company/meridian_platform/observability_store.py. Because Python'ssqlite3driver does not support parameterized queries (?) forPRAGMAstatements, this direct concatenation creates a risk of SQL injection or execution disruption if the environment variable is manipulated.π― Impact: While an attacker would need control over the process environment variables, successfully manipulating this variable could allow them to crash the database connection, alter other PRAGMA configurations, or potentially execute arbitrary statements depending on the underlying SQLite version's PRAGMA handling.
π§ Fix: Added strict allowlist validation (
{'DELETE', 'TRUNCATE', 'PERSIST', 'MEMORY', 'WAL', 'OFF', 'DEFAULT', ''}). If the configured journal mode is not in this safe set, it safely falls back to the default'WAL'mode before the string is formatted into the SQL command.β Verification: Ran the test suite for
meridian_platformusingPYTHONPATH=intelligence/company/meridian_platform:intelligence:kernel python3 -m unittest discover -s intelligence/company/meridian_platform -p 'test_*.py'. Verified that the fallback mechanism works safely without introducing new regressions. Checked diff viagit diff.PR created automatically by Jules for task 13737727808466033423 started by @mapleleaflatte03