feat: split agent-code-review Hard Stop into judgment/approval contracts - #131
Open
akane-cat[bot] wants to merge 1 commit into
Open
feat: split agent-code-review Hard Stop into judgment/approval contracts
#131akane-cat[bot] wants to merge 1 commit into
akane-cat[bot] wants to merge 1 commit into
Conversation
- Introduced `judgment-contract.md` and `approval-contract.md` templates to define hard stop requirements for steps 4 and 5-6, respectively. - Updated `manifest.yaml` to include references to the new contract templates, ensuring proper validation and documentation of the review process. - Enhanced existing templates and checklists to reflect the new hard stop conditions and required reads, improving clarity and compliance in the workflow. - Modified test scripts to skip certain checks for contracts classified as "foundation," ensuring appropriate handling of specific profiles. This update aims to formalize the review process within the agentic workflow, enhancing the structure and clarity of approval and judgment requirements.
Owner
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthrough判定契約と承認契約を追加しました。 Changesコードレビュー契約フロー
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-code-review スキルの Step 4 / Step 5-6 の Hard Stop を、専用 contract ファイル（
judgment-contract.md/approval-contract.md）へ分離する。突入時は contract の全文 Read を必須とし、protocol / loop 等の詳細参照は条件付き Read に変更してコンテキストを削減しつつ、不変条件（J1–J13 / A1–A13）のトレーサビリティを維持する。Changes
judgment-contract.md.template/approval-contract.md.templateを新設（Hard Stop 正 + 常駐不変条件 + 追加 Read トリガー）SKILL.md.templateの Step Gate Matrix / Step 4 / Step 5-6 / 関連ドキュメント表を contract 参照へ切替judgment-protocol.md/approval-loop.md/checklist.md/mode-b-reminder.mdを「条件付き詳細 SoT」へ位置づけ更新required_sections検証を追加test_contract_loop5/7/8.pyで foundation profile 時の pnpm 系チェックを SKIPTest plan
bin/foundation-gate generateで contract 生成物が manifest 定義どおり出力されるbin/foundation-gate selfが PASS するagent-code-review/SKILL.mdの Step 4 / 5-6 Hard Stop が contract 参照になっているjudgment-contract.md/approval-contract.mdに J1–J13 / A1–A13 が含まれるSummary by CodeRabbit
改善
テスト