Fix Awal review findings#2
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1905393f17
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if script is not None: | ||
| script_name, display = script | ||
| if script_name not in surface.package_scripts: | ||
| if not surface.has_package_json: |
There was a problem hiding this comment.
This new missing_package_manifest check assumes every npm/pnpm/yarn script command should be backed by a root-level package.json, which creates false high-severity blocks for valid README flows that first cd into a subdirectory (for example, cd web then npm run dev with web/package.json). I verified this in the current code path: the scanner reports missing_package_manifest even when the script exists in the target subproject, so monorepo or multi-package repos are now incorrectly flagged as broken.
Useful? React with 👍 / 👎.
1 participant
What changed
yarn run devas thedevscript instead ofrun.os.environ["KEY"]env usage.Why
These were the review gaps from the first Awal pass. Without them, Awal could miss broken first-run instructions in repos with missing package manifests, Yarn commands, or Python env access.
Validation
PYTHONPATH=src python3 -m unittest discover -s testspython3 -m compileall src testsPYTHONPATH=src python3 -m awal examples/clean-appPYTHONPATH=src python3 -m awal examples/broken-app --fail-on highpython3 -m pip wheel . -w /tmp/awal-fix-wheel@justAbdulaziz10 please review before making it final.