fix: use tempfile.gettempdir() for cross-platform tmp cleanup#115
Open
marceljungle wants to merge 1 commit into
Open
fix: use tempfile.gettempdir() for cross-platform tmp cleanup#115marceljungle wants to merge 1 commit into
marceljungle wants to merge 1 commit into
Conversation
The cleanup function was hardcoded to /tmp/tmp*.tmp which only works on Linux. On macOS, tempfile writes to $TMPDIR (/var/folders/...), and on Windows to %TEMP%, causing orphaned files to never be cleaned up and eventually filling the disk.
Contributor
|
|
Contributor
Release Preview for v0.7.3
🚀 Features
🐛 Fixes
🔧 Chores
📝 Other Changes
|
1 similar comment
Contributor
Release Preview for v0.7.3
🚀 Features
🐛 Fixes
🔧 Chores
📝 Other Changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_cleanup_stale_tmp_files()was hardcoded to glob/tmp/tmp*.tmp, which only works on Linux. On macOS, Python'stempfilemodule writes to$TMPDIR(/var/folders/.../T/), and on Windows to%TEMP%. This caused orphaned.tmpaudio files to accumulate indefinitely on non-Linux systems, eventually filling the disk.Fix
Replace the hardcoded
/tmppath withtempfile.gettempdir()+os.path.join(), which resolves to the correct platform-specific temp directory on Linux, macOS, and Windows.