RHS Coach tab for RSI judgments and dispositions - #64
Merged
Conversation
Bare-list v1 of the owner-visible RSI coach surface: a third RHS bottom tab beside Frontier and Transcript, fed by GET /api/rsi/dispositions. Each row shows the judgment (name/observation), severity, retro provenance (T353), delivered time, evidence summary and the disposition chip, plus the target id / reason once the overseer has dispositioned it. Honest states are the point here, so they are kept distinct: - empty store → calm "no coach judgments yet", never an error; - fetch failure → loud error, never a blank list that reads as "the coach found nothing" (a quiet poll keeps the last good list instead); - pending is the only loud chip, since it is what wants the owner's eye. nextBottomTab now admits three panes and keeps the current pane on an unknown click rather than yanking the owner back to Frontier. Rows are built with textContent, not innerHTML: judgment text is model-authored. Hermetic: web/scripts/rsi_dispositions_test.js (wired into make test-web) covers empty / error / pending+ignored+filed / sort / unknown-disposition / Go zero-time. go test ./... green, including the embed-coverage guard that caught the missing //go:embed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AwjoJNpsxEnBGup8hiamyC
Restores and completes the UI half of T354. c6d6670 landed only the JS module and its test: a concurrent release session reset master to origin/master mid-edit, which reverted the web/index.html markup+CSS+ wiring and the frontier_table.js tab change out of the working tree before that commit was made (its own test was left failing as a result). Bare-list v1 of the owner-visible RSI coach surface: a third RHS bottom tab beside Frontier and Transcript, fed by GET /api/rsi/dispositions. Each row shows the judgment (name/observation), severity, retro provenance (T353), delivered time, evidence summary and the disposition chip, plus the target id / reason once the overseer has dispositioned it. Honest states are the point here, so they are kept distinct: - empty store → calm "no coach judgments yet", never an error; - fetch failure → loud error, never a blank list that reads as "the coach found nothing" (a quiet poll keeps the last good list instead); - pending is the only loud chip, since it is what wants the owner's eye. nextBottomTab now admits three panes and keeps the current pane on an unknown click rather than yanking the owner back to Frontier. Rows are built with textContent, not innerHTML: judgment text is model-authored. Green: go test ./... , make test-web (rsi_dispositions_test.js now passes), make test-ui. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AwjoJNpsxEnBGup8hiamyC
Includes T354 RHS Coach dispositions list (after owner order to wait for T354).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up release after v0.12.0 so the owner-ordered T354 Coach list ships.
Owner instruction: Wait for T354 before doing the release — v0.12.0 went out early; this PR is the T354-inclusive cut (v0.13.0).
Contents
GET /api/rsi/dispositions(judgment list + disposition chips)Test plan
go test ./internal/server -run RSInode web/scripts/rsi_dispositions_test.jscurl :13705/api/rsi/dispositions→ 200