Fix handling of cluster in ddd()#26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in ddd() when the cluster parameter is used rised in issue #25. If a cluster variable is provided, the function now defaults to multiplier bootstrap with cband = TRUE and validates that the cluster variable is time-invariant.
Changes
• When cluster is supplied, use multiplier bootstrap and set cband = TRUE for clustered inference sending a warning for the user.
• Validate that the cluster variable is time-invariant; error with a clear message if not.
• Add unit tests covering clustered paths and the time-invariance check.
Notes
• No API changes beyond stricter validation.
• Backward compatible for users not passing cluster.