Skip to content

Replace deprecated BMisc function names#34

Merged
marcelortizv merged 1 commit into
marcelortizv:mainfrom
bcallaway11:fix-bmisc-deprecated-calls
May 25, 2026
Merged

Replace deprecated BMisc function names#34
marcelortizv merged 1 commit into
marcelortizv:mainfrom
bcallaway11:fix-bmisc-deprecated-calls

Conversation

@bcallaway11
Copy link
Copy Markdown
Contributor

@bcallaway11 bcallaway11 commented May 25, 2026

Summary

BMisc deprecated several legacy function names in v1.4.9 (released 2025) and will remove them in the next minor release. This PR replaces the five call sites in R/preprocess.R that trigger deprecation warnings during R CMD check:

  • BMisc::makeBalancedPanel()BMisc::make_balanced_panel() (3 occurrences)
  • BMisc::rhs.vars()BMisc::rhs_vars() (2 occurrences)

No behaviour change — these are direct renames with identical signatures.

Test plan

  • R CMD check on this branch produces no deprecation warnings from BMisc
  • Existing examples and tests pass

🤖 Generated with Claude Code

BMisc::makeBalancedPanel -> BMisc::make_balanced_panel (3 sites)
BMisc::rhs.vars -> BMisc::rhs_vars (2 sites)

These functions were deprecated in BMisc 1.4.9 and will be removed in
the next release. This change eliminates the deprecation warnings that
appear during R CMD check.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@marcelortizv marcelortizv self-requested a review May 25, 2026 17:28
@marcelortizv marcelortizv merged commit 2934dcc into marcelortizv:main May 25, 2026
1 check passed
@marcelortizv
Copy link
Copy Markdown
Owner

Thanks Brant! PR has been merged @bcallaway11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants