Skip to content

Change return type of cre2_set_compile from int to bool #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hopper-vul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change return type of cre2_set_compile from int to bool #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cre2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,11 +718,11 @@ cre2_set_add_simple(cre2_set *set, const char *pattern)


// Compile the regex set into a DFA. Must be called after add and before match.
int
bool
cre2_set_compile(cre2_set *set)
{
RE2::Set *s = TO_RE2_SET(set);
return static_cast<int>(s->Compile());
return s->Compile();
}

// Match the set of regex against text and store indices of matching regexes in match array.
Expand Down
4 changes: 2 additions & 2 deletions src/cre2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,8 @@ cre2_decl int cre2_set_add(cre2_set *set, const char *pattern, size_t pattern_le
cre2_decl int cre2_set_add_simple(cre2_set *set, const char *pattern);

/* Compile the regex set into a DFA. Must be called after add and before match.
* Returns 1 on success, 0 on error */
cre2_decl int cre2_set_compile(cre2_set *set);
* Returns true on success, false on error */
cre2_decl bool cre2_set_compile(cre2_set *set);

/* Match the set of regex against text and store indices of matching regexes in match array.
* Returns the number of regexes which match. */
Expand Down