Skip to content

Formatter: Make Tailwind Class Rewriter work on Action View Tags - #1441

Draft
marcoroth wants to merge 1 commit into
mainfrom
erb-tailwind-class-formatting
Draft

Formatter: Make Tailwind Class Rewriter work on Action View Tags#1441
marcoroth wants to merge 1 commit into
mainfrom
erb-tailwind-class-formatting

Conversation

@marcoroth

@marcoroth marcoroth commented Mar 21, 2026

Copy link
Copy Markdown
Owner

Resolves #907

@github-actions github-actions Bot added formatter @herb-tools/formatter for HTML+ERB templates javascript JavaScript source across the javascript/ packages typescript TypeScript source across the javascript/ packages rewriter @herb-tools/rewriter AST and string transformation system labels Mar 21, 2026
@marcoroth marcoroth added the tailwind-class-sorter @herb-tools/tailwind-class-sorter Tailwind CSS class sorting label Mar 21, 2026
@github-actions

github-actions Bot commented Mar 21, 2026 •
edited
Loading

Copy link
Copy Markdown

馃尶 Interactive Playground and Documentation Preview

A preview deployment has been built for this pull request. Try out the changes live in the interactive playground:

馃尡 Grown from commit d0309af

@pkg-pr-new

pkg-pr-new Bot commented Mar 21, 2026

Copy link
Copy Markdown 
npx https://pkg.pr.new/@herb-tools/formatter@1441

npx https://pkg.pr.new/@herb-tools/language-server@1441

npx https://pkg.pr.new/@herb-tools/linter@1441

commit: d0309af

@marcoroth marcoroth added the action-view-helpers Action View helper support and metadata label Apr 5, 2026
@drale2k

drale2k commented Apr 10, 2026

Copy link
Copy Markdown

Is this ready for testing?

@marcoroth

marcoroth commented Apr 10, 2026

Copy link
Copy Markdown
Owner Author

@drale2k technically yes, but I wanted to do more manual testing to make sure this doesn't break things.

I'm also not too happy with the implementation itself, as it involved rewriting the rewriter from pre to post and would break all .herb.yml configs.

@drale2k

drale2k commented Apr 10, 2026

Copy link
Copy Markdown

@drale2k technically yes, but I wanted to do more manual testing to make sure this doesn't break things.

I'm also not too happy with the implementation itself, as it involved rewriting the rewriter from pre to post and would break all .herb.yml configs.

Ok roger, then will wait out and test when it is closer to final shape

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

action-view-helpers Action View helper support and metadata formatter @herb-tools/formatter for HTML+ERB templates javascript JavaScript source across the javascript/ packages rewriter @herb-tools/rewriter AST and string transformation system tailwind-class-sorter @herb-tools/tailwind-class-sorter Tailwind CSS class sorting typescript TypeScript source across the javascript/ packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Formatter: Tailwind sort ERB classes

2 participants

@marcoroth @drale2k