Skip to content

Formatter: Don't space children of text-level elements - #1951

Draft
marcoroth wants to merge 1 commit into
mainfrom
space-text-level-elements
Draft

Formatter: Don't space children of text-level elements#1951
marcoroth wants to merge 1 commit into
mainfrom
space-text-level-elements

Conversation

@marcoroth

@marcoroth marcoroth commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Follow up on #1950, which stopped the formatter from forcing a blank line before a trailing comment. This pull request fixes the same underlying problem one level up: the formatter inserts blank lines between the children of an element whose content is a single run of text.

Related #436

@github-actions github-actions Bot added formatter @herb-tools/formatter for HTML+ERB templates typescript TypeScript source across the javascript/ packages labels Aug 1, 2026
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

馃尶 Interactive Playground and Documentation Preview

A preview deployment has been built for this pull request. Try out the changes live in the interactive playground:


馃尡 Grown from commit 22043ca

@pkg-pr-new

pkg-pr-new Bot commented Aug 1, 2026

Copy link
Copy Markdown
npx https://pkg.pr.new/@herb-tools/formatter@1951
npx https://pkg.pr.new/@herb-tools/language-server@1951
npx https://pkg.pr.new/@herb-tools/linter@1951

commit: 22043ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

formatter @herb-tools/formatter for HTML+ERB templates typescript TypeScript source across the javascript/ packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant