Skip to content

Linter CLI: Preserve spacing in new rule hints - #2022

Open
joeeei11 wants to merge 1 commit into
marcoroth:mainfrom
joeeei11:fix/issue-2021-rule-spacing
Open

Linter CLI: Preserve spacing in new rule hints#2022
joeeei11 wants to merge 1 commit into
marcoroth:mainfrom
joeeei11:fix/issue-2021-rule-spacing

Conversation

@joeeei11

@joeeei11 joeeei11 commented Aug 5, 2026

Copy link
Copy Markdown

Summary

  • keep the separating whitespace inside the gray ANSI sequence for version labels
  • add a regression test for the hyperlink-to-color escape boundary

Testing

  • yarn workspace @herb-tools/linter test test/summary-reporter.test.ts

Closes #2021

@github-actions github-actions Bot added linter @herb-tools/linter for HTML+ERB templates typescript TypeScript source across the javascript/ packages labels Aug 5, 2026
vi.restoreAllMocks()
})

test("keeps the space before a version label inside its color sequence", () => {

@marcoroth marcoroth Aug 5, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeeei11 would you mind moving this to the existing cli.test.ts and using toMatchSnapshot on the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linter @herb-tools/linter for HTML+ERB templates typescript TypeScript source across the javascript/ packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linter CLI: Missing space after rule name in New rules available hint

2 participants