Conversation
github-actions
Bot
added
documentation
marcoroth
force-pushed
the
ujs-rules
branch
3 times, most recently
from
August 7, 2026 01:56
f245769 to
978f814
Compare
github-actions
Bot
added
wasm
marcoroth
force-pushed
the
ujs-rules
branch
3 times, most recently
from
August 7, 2026 01:59
98902d3 to
5542d9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements four linter rules under a new
ujs-scope, covering thedata-*attributes that@rails/ujsused to power.Before Rails 7, Rails shipped
@rails/ujsby default, which added JavaScript behavior to elements through helper options anddata-*attributes.Rails 7 stopped including it, and Turbo covers the same behavior with its own attributes. A template that still has the old attributes only does what it says while the legacy library is loaded, and once that goes away it fails quietly.
These rules are meant to help with the migration to Turbo.
ujs-prefer-turbo-method:data-method, →data-turbo-methodujs-prefer-turbo-confirm:data-confirm, →data-turbo-confirmujs-prefer-turbo-submits-with:data-disable-with, →data-turbo-submits-withujs-no-remote-attribute:data-remote→ noneResolves #1346