Parser: Properly detect locals that shadow Action View helpers - #2076
Merged
Conversation
marcoroth
enabled auto-merge (squash)
August 7, 2026 18:18
marcoroth
force-pushed
the
actionview-helper-shadowing
branch
from
August 7, 2026 18:19
734f97d to
7a63be1
Compare
marcoroth
force-pushed
the
actionview-helper-shadowing
branch
from
August 7, 2026 18:19
7a63be1 to
db558f3
Compare
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #1900.
#1900 taught the
action_view_helperstransform to leave block arguments alone, so<%= tag.name %>inside<% @tags.each do |tag| %>stopped turning into a<name>element. It only covered block arguments though, and every other way of binding a local still shadowed nothing:The
tag.namecall was still analyzed as the Action Viewtagbuilder, which surfaced through thehtml-no-unknown-taglinter rule as:This pull request resolves helper shadowing against a single Prism parse of the whole template instead of tracking scopes by hand.
Related #1762