Language Service: Resolve partials against the view root the index found

[marcoroth]

This pull request fixes go to definition for projects that do not keep their templates in app/views.

DefinitionProvider located a project's view root by looking for a literal string in the document path:

const VIEWS_DIRECTORY = "/app/views/"

A project laid out any other way never matched, so it got no view root at all, and go to definition could only find partials that happen to sit in the same directory as the file being edited:

app/templates/events/show.html.erb

<%= render "shared/header" %>

Nothing resolves, even though app/templates/shared/_header.html.erb is right there.

buildPartialIndex does not assume the conventional layout. It looks for app/views, falls back to the project root when there is nothing there, and records the answer as viewRoot. So what was needed to resolve that render call was already sitting in the project's index, unused by this provider.

Follow up on #2168.

[github-actions]

🌿 Interactive Playground and Documentation Preview

A preview deployment has been built for this pull request. Try out the changes live in the interactive playground:

• Playground Preview
• Documentation Preview
• Website Preview

---

_{🌱 Grown from commit 6add25c}

---

✅ Preview deployment has been cleaned up.

[pkg-pr-new]

npx https://pkg.pr.new/@herb-tools/formatter@2184

npx https://pkg.pr.new/@herb-tools/language-server@2184

npx https://pkg.pr.new/@herb-tools/linter@2184

commit: 6add25c