Skip to content

Language Service: Move ReferencesProvider out of the language server - #2186

Merged
marcoroth merged 1 commit into
analysis-project-indexfrom
language-service-references-provider
Aug 11, 2026
Merged

Language Service: Move ReferencesProvider out of the language server#2186
marcoroth merged 1 commit into
analysis-project-indexfrom
language-service-references-provider

Conversation

@marcoroth

@marcoroth marcoroth commented Aug 11, 2026

Copy link
Copy Markdown
Owner

This pull request moves the last of the providers into @herb-tools/language-service.

ReferencesProvider stayed behind in #2162 because it dependent on things that couldn't be offered by the package yet. #2168 and ProjectIndex removed most of that, and what was left came down to three small dependencies.

Project was used for this.project.root, twice. ProjectIndex already exposes root, so the dependency disappears rather than moving.

Documents was used for one call, this.documents.get(uri), to prefer an open buffer over what is on disk. That is a two line interface, so the provider no longer reaches into the language server's document store:

node:fs and node:path follow the pattern the other moved providers already use. readFileSync becomes a required injected read, matching DefinitionProvider, and join comes from the package's own posix_path.

The read closure is now built once in Session and shared through SharedServices.

@github-actions github-actions Bot added language-server @herb-tools/language-server and Language Server Protocol support typescript TypeScript source across the javascript/ packages language-service @herb-tools/language-service HTML+ERB language service labels Aug 11, 2026
@marcoroth
marcoroth marked this pull request as ready for review August 11, 2026 17:45
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

🌿 Interactive Playground and Documentation Preview

A preview deployment has been built for this pull request. Try out the changes live in the interactive playground:


🌱 Grown from commit 60dd24d


✅ Preview deployment has been cleaned up.

@pkg-pr-new

pkg-pr-new Bot commented Aug 11, 2026

Copy link
Copy Markdown
npx https://pkg.pr.new/@herb-tools/formatter@2186
npx https://pkg.pr.new/@herb-tools/language-server@2186
npx https://pkg.pr.new/@herb-tools/linter@2186

commit: 60dd24d

@marcoroth
marcoroth merged commit ecab01f into main Aug 11, 2026
37 of 39 checks passed
@marcoroth
marcoroth deleted the language-service-references-provider branch August 11, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

language-server @herb-tools/language-server and Language Server Protocol support language-service @herb-tools/language-service HTML+ERB language service typescript TypeScript source across the javascript/ packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant