Language Service: Move ReferencesProvider out of the language server - #2186
Merged
marcoroth merged 1 commit intoAug 11, 2026
Merged
Conversation
marcoroth
marked this pull request as ready for review
August 11, 2026 17:45
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request moves the last of the providers into
@herb-tools/language-service.ReferencesProviderstayed behind in #2162 because it dependent on things that couldn't be offered by the package yet. #2168 andProjectIndexremoved most of that, and what was left came down to three small dependencies.Projectwas used forthis.project.root, twice.ProjectIndexalready exposesroot, so the dependency disappears rather than moving.Documentswas used for one call,this.documents.get(uri), to prefer an open buffer over what is on disk. That is a two line interface, so the provider no longer reaches into the language server's document store:node:fsandnode:pathfollow the pattern the other moved providers already use.readFileSyncbecomes a required injectedread, matchingDefinitionProvider, andjoincomes from the package's ownposix_path.The
readclosure is now built once inSessionand shared throughSharedServices.