Analysis: Map state down to the nodes that read it - #2189
Merged
Conversation
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request takes dependency tracking from the file level to the node level.
affectedTemplatesanswers which templates a change invalidates. That is enough to decide what to re-render, but not enough to decide what to re-render within a template.dependencyIndexanswers the finer question:Each entry records what kind of node reads the state, the expression that reads it, where it is, and a path of child indices leading back to it.
text_contentfor an ERB tag in the body,attribute_valuefor one inside an attribute, which also records which attribute:renderfor a call that passes state to another template, andconditionalfor anif,unlessorcase. A conditional counts when anything inside it reads the state, not just its own condition, because the whole branch is what gets re-rendered:@adminis read by the condition, and@postby the body, so both map to the conditional, and@postmaps to the inner tag as well.