Analysis: Rename PartialCallerIndex to RenderGraph and answer both directions - #2190
Merged
Merged
Conversation
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request lets a rule ask what a render call hands back, which is what #2100 needs.
Today a rule can ask what encloses a partial.
ancestorVerdictwalks up from a partial through everything that renders it and answersalways,never,mixedorunknown.But, there was no way to ask the same question downwards, so this reports an offense it should not:
_panel.html.erb:_summary.html.erb:The index already held both ends of every edge.
callSitesis keyed by callee, and each site records its caller, so the render relationships were all there. Only the queries were direction-specific.What was missing is a property of the node to answer what a template puts at its own top level. Each template now records its
TemplateRoots, the tags at its root, split into unconditional and conditional, along with the renders sitting at root position, resolved to files while the builder still has the partial index in hand.That is why the class is renamed.
PartialCallerIndexdescribed one direction of something that now answers both.