Respect validation_mode for external .herb templates - #116
Merged
Conversation
…d validation mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #115.
When a gem ships a
.html.herbtemplate, it reachesReActionView::Template::Handlers::Herbstraight from the railtie. It never passes throughHandlers::ERB, so nothing is in a position to rescue it.#115 nonetheless forced
validation_mode: :raisefor every external template, including those, which turned what used to be a validation overlay into an uncaught exception on a template the application cannot edit:The mistake was putting the decision in
Handlers::Herb, which cannot tell whether its caller will rescue.validation_mode_foris gone, and the mode is now passed in by the handler that owns therescue.Related #115