Add regression test for heredoc with trailing arguments - #117
Merged
Conversation
The compiled Ruby for an ERB expression containing a heredoc needs the closing parenthesis on its own line after the heredoc terminator. That is handled by `Herb::Engine#trailing_newline`, but the handler override in `ReActionView::Template::Handlers::Herb::Herb#add_expression` had no test covering it. Ported from #78 by @pinzonjulian, which is otherwise obsolete since the fix landed upstream in marcoroth/herb#1206. Co-authored-by: Juli谩n Pinz贸n Eslava <julian@buildkite.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiled Ruby for an ERB expression containing a heredoc needs the closing parenthesis on its own line after the heredoc terminator. That is handled by
Herb::Engine#trailing_newline, but the handler override inReActionView::Template::Handlers::Herb::Herb#add_expressionhad no test covering it.Ported from #78 by @pinzonjulian, which is otherwise obsolete since the fix landed upstream in marcoroth/herb#1206.
Resolves #78