Skip to content

Fix dev tools event listener leak on Turbo navigation #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
marcoroth wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Draft

Fix dev tools event listener leak on Turbo navigation #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions javascript/packages/dev-tools/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ if (typeof window !== "undefined" && typeof document !== "undefined") {
let isInitializing = false

const initializeDevTools = () => {
if (ReActionViewDevTools.getInstance()) {
return
}

if (isInitializing) {
console.log("ReActionView dev tools initialization already in progress, skipping...")

Expand Down Expand Up @@ -109,8 +113,6 @@ if (typeof window !== "undefined" && typeof document !== "undefined") {
}

document.addEventListener("turbo:load", initializeDevTools)
document.addEventListener("turbo:render", initializeDevTools)
document.addEventListener("turbo:visit", initializeDevTools)
}

declare global {
Expand Down
Loading