Repository navigation
v0.14.0 - #1294
Merged
Merged
v0.14.0#1294
Conversation
…ssertions - Upgrade ESLint rule severity from 'warn' to 'error' for: * no-restricted-imports (relative imports) * @typescript-eslint/no-unnecessary-type-assertion * @typescript-eslint/no-unnecessary-condition * @typescript-eslint/consistent-type-assertions - Fix all type assertion violations across codebase - Add eslint-disable comments where type assertions are necessary - Update 55 files to comply with stricter type safety rules - Improve code quality and type safety enforcement Closes #959 #960 #961
refactor: upgrade ESLint rules from warnings to errors and fix type assertions
- Add isScanning state to control EANReader rendering lifecycle - Stop rendering EANReader before modal closure to trigger onCleanup - Add 100ms delay to ensure component cleanup completes before actions - Apply fix to both auto-select and manual cancel scenarios - Resolves camera staying active in background after successful scan Fixes #1018
…ent cleanup" This reverts commit 16b10a1.
fix(ean): ensure camera stops after EAN scan by proper component cleanup
…e limits - Replace sliding window logic with fixed calendar-based periods - Use earliest timestamp as stable anchor point instead of latest - Add 3-month (3m) period with 7-day intervals - Implement responsive candle limits (6 mobile, 12 desktop) - Add comprehensive test suite for period stability verification - Ensure historical OHLC candles remain unchanged when new data is added Fixes #1017
…ed period calculation - Add mobile detection and responsive period adjustments to weightEvolutionDomain - Modify getCandlePeriod and groupWeightsByPeriod to accept isMobile parameter - Implement mobile-specific candle limits and period scaling - Update chart height for better mobile experience (400→500px) - Simplify WeightChart data flow by removing redundant period limitations - Refactor WeightChartOptions and WeightChartTooltip to use GroupedWeightsByPeriod - Add 3-month period option to chart settings - Update all test cases to include isMobile parameter - Optimize chart animations and toolbar for mobile devices
fix(weight-chart): fix OHLC period stability and add mobile responsiveness
- Document current command structure analysis - Identify optimization opportunities for issue discovery - Define context preservation protocols between agents - Establish risk assessment framework for improvements - Create implementation roadmap ordered by risk level
- Create comprehensive issue discovery automation - Correlate TODO comments with existing GitHub issues - Provide consolidated findings with actionable recommendations - Support feature-area and search-term parameters - Integrate with existing command workflow patterns - Update command documentation and daily workflow This low-risk addition optimizes development workflow by preventing duplicate issue creation and providing better context for decisions.
- Add Memory Integration sections to fix, create-issue, and implement commands - Enable context loading from workflow optimization patterns - Integrate smart defaults and pattern recognition - Improve workflow awareness between commands - Maintain consistency with project conventions Medium-risk improvement that enhances existing commands without breaking functionality while adding intelligent context awareness.
- Add /workflow-context command for shared context between commands - Create agent context handoff protocol memory for state preservation - Enable context saving/loading across workflow phases - Implement structured context for discovery, implementation, quality phases - Add intelligent context prediction and workflow continuity - Support cross-agent context preservation and learning Medium-risk improvement that bridges workflow gaps without breaking existing functionality while enabling intelligent context awareness.
- Add /orchestrate command for automated multi-step workflows - Support feature-development, bug-investigation, issue-resolution workflows - Implement intelligent command routing and context management - Add adaptive workflow execution with error recovery - Integrate quality gates and solo project optimizations - Update workflow documentation to recommend orchestration High-risk improvement that provides comprehensive workflow automation while maintaining full compatibility and user control.
- Set eslint solid/reactivity rule to 'error' for strict validation - Fix UnifiedRecipeEditView props reactivity with untrack for aliases - Fix useHashTabs event handler with onCleanup instead of return - All warnings resolved while maintaining proper reactive behavior Fixes #963
fix(reactivity): resolve solid/reactivity warnings
- Add bootstrap() call to acceptDayChange() function to ensure day data is refetched when user accepts day change - Update test mocks to properly handle bootstrap function dependencies (showPromise and currentUserId) - Resolves issue where current day appears as non-existent after day change modal acceptance Fixes #1020
fix(day-diet): refetch data after accepting day change
…tructure layer Move all registerSubapabaseRealtimeCallback calls from application layer to infrastructure layer following clean architecture principles. Each module now has a dedicated realtime subscription setup function in its infrastructure layer. Changes: - Add setupDayDietRealtimeSubscription to day-diet infrastructure - Add setupMacroProfileRealtimeSubscription to macro-profile infrastructure - Add setupUserRealtimeSubscription to user infrastructure - Add setupWeightRealtimeSubscription to weight infrastructure - Update all application layers to use infrastructure abstractions - Remove unused SUPABASE_TABLE_* imports from application layers Resolves issue #981
… layer Add ESLint rule that restricts imports from '~/shared/utils/supabase' to infrastructure layer only, enforcing clean architecture principles. Changes: - Add no-restricted-imports rule for supabase utils in eslint.config.mjs - Allow supabase imports only in infrastructure/** files and specific exceptions - Move search cache functions from application to infrastructure layer - Update search application layer to re-export infrastructure functions - Ensure all quality checks pass with new architectural constraints This prevents application and domain layers from directly accessing Supabase, requiring proper use of repository abstractions.
…-4afb-a1b4-a17f76459c88 Enhance semver.sh with Robust Error Handling and Retry Logic for GitHub API Rate Limiting
…-4683-b6f7-6e1502538bf6 Fix: Weight UI does not update after add/remove/edit operations
…-4956-a5c4-172971415b02 Fix: Enable macro goal editing for new users without existing profiles
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements v0.14.0 which appears to be a significant refactoring focused on modularizing the codebase architecture and standardizing data access patterns. The changes demonstrate a shift from direct database access to a more structured gateway/repository pattern while also implementing comprehensive error handling and logging improvements.
Key Changes:
- Refactored data access layer to use gateway/repository pattern with proper separation of concerns
- Replaced custom error handling system with standardized logging utilities
- Updated user identification from numeric IDs to UUID strings across all modules
- Implemented comprehensive test coverage for new modules and functionality
Reviewed Changes
Copilot reviewed 224 out of 377 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/user/application/tests/userCreationHelper.test.ts | New test file for user creation helper functionality |
| src/modules/toast/ui/solidToast.ts | Simplified error handling by removing custom error handler |
| src/modules/toast/ui/ExpandableErrorToast.tsx | Changed exported types to internal types for better encapsulation |
| src/modules/toast/tests/*.test.ts | Added proper mocking for environment and logging dependencies |
| src/modules/toast/infrastructure/toastSettings.ts | Improved error handling in localStorage operations |
| src/modules/toast/infrastructure/clipboardErrorUtils.ts | Replaced custom error handling with logging utilities |
| src/modules/toast/domain/toastTypes.ts | Removed audience concept from toast system |
| src/modules/toast/domain/errorMessageHandler.ts | Enhanced debugging with conditional logging |
| src/modules/toast/application/*.ts | Standardized logging and removed audience parameter |
| src/modules/template-search/application/*.ts | Updated import paths and simplified debounce configuration |
| src/modules/search/* | Complete rewrite using new architecture patterns |
| src/modules/recent-food/* | Migrated from DAO to DTO pattern with proper domain separation |
| src/modules/observability/* | New observability module with Sentry integration |
| src/modules/measure/* | Updated user ID type and improved repository pattern |
| src/modules/diet/* | Extensive refactoring with improved type safety and architecture |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.