Add deterministic coverage for clipboard extractItems

[Copilot]

extractItems is responsible for normalizing clipboard payloads into items while regenerating item IDs. This adds focused domain-level coverage for the three supported payload shapes so regressions in extraction and ID regeneration are caught early.

• Coverage added for all payload variants

  • single UnifiedItem payload
  • Meal payload with multiple items
  • Recipe payload with multiple items

• ID regeneration behavior verified

  • asserts extracted items receive regenerated IDs instead of reusing source IDs
  • checks the current codebase ID generation shape (Math.round(Math.random() * 1000000)) with deterministic mocks
  • verifies extracted items preserve their non-ID content

• Test structure

  • adds a dedicated clipboard domain test file alongside existing clipboard tests
  • uses small fixture helpers to keep payload setup readable across item, meal, and recipe cases

vi.spyOn(Math, 'random')
  .mockReturnValueOnce(0.111111)
  .mockReturnValueOnce(0.222222)

const extractedItems = ClipboardPayloadExt.extractItems(payload)

expect(extractedItems).toEqual([
  { ...items[0], id: 111111 },
  { ...items[1], id: 222222 },
])

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• test.supabase.co
  • Triggering command: /opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node --conditions node --conditions development /home/REDACTED/work/macroflows/macroflows/node_modules/.pnpm/tinypool@1.1.1/node_modules/tinypool/dist/entry/process.js tems (dns block)
  • Triggering command: /opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node --conditions node --conditions development /home/REDACTED/work/macroflows/macroflows/node_modules/.pnpm/tinypool@1.1.1/node_modules/tinypool/dist/entry/process.js ame rgo/bin/git credential.usern/bin/sh (dns block)
  • Triggering command: /opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node --conditions node --conditions development /home/REDACTED/work/macroflows/macroflows/node_modules/.pnpm/tinypool@1.1.1/node_modules/tinypool/dist/entry/process.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>The extractItems method lacks test coverage. This is a critical function that extracts and regenerates IDs for items from different payload types. Add tests to verify:</issue_title>
<issue_description>reportedBy: github-copilot.v1/refine-github-issue

Task: Add unit tests for extractItems to cover all payload types

Title:
Add unit tests for extractItems covering single items, meal items, and recipe items; verify ID regeneration.

Description:
The extractItems method extracts items and regenerates IDs for items coming from different payload types (single item, meal items, recipe items). This function is critical and currently lacks test coverage. We need deterministic tests that validate behavior across payload shapes and ensure IDs are regenerated correctly (no collisions, correct new ID format expected by the codebase).

Motivation:
Unit tests will prevent regressions in the item extraction logic and ensure downstream code is working with correctly-regenerated IDs.

Acceptance Criteria:

• Add tests for single-item extraction: the returned item has a newly generated ID and preserved content.
• Add tests for meal items (multiple items): all extracted items receive new unique IDs; original items array structure is handled correctly.
• Add tests for recipe items (multiple items): same verification as meal items.
• Test(s) assert that regenerated IDs conform to the expected format/structure used by the codebase.
• Tests added to the appropriate test file(s) and pass in CI.

Files / Scope:

• Unit tests should be added alongside existing tests for related modules (e.g., src/modules/.../clipboard or the module where extractItems is implemented). Update/choose the test file path consistent with repository test organization.

Additional Context / Notes:

• See original PR discussion: (reference: PR 1319 comments)
• If helpful, include fixtures for the different payload types to keep tests readable and robust.
  </issue_description>

<agent_instructions>pnpm check always green</agent_instructions>

Comments on the Issue (you are @copilot in this section)

• Fixes The extractItems method lacks test coverage. This is a critical function that extracts and regenerates IDs for items from different payload types. Add tests to verify: #1354

---

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
macroflows	Ready	Preview, Comment	Mar 24, 2026 9:46pm

[Copilot]

Pull request overview

Adds deterministic unit tests for ClipboardPayloadExt.extractItems, which normalizes different clipboard payload shapes into a flat Item[] while regenerating IDs. This improves domain-level regression protection around clipboard extraction behavior.

Changes:

• Added focused extractItems tests for all supported payload variants (single Item, Meal, Recipe).
• Verified regenerated IDs are produced (vs reusing source IDs) using deterministic Math.random mocks.
• Asserted extracted items preserve non-ID content and do not mutate source payload content.