Skip to content

fix(release): close superseded Scoop-bump PRs before opening a new one - #302

Closed
marianogappa wants to merge 1 commit into
mainfrom
fix/scoop-close-stale-bump-prs
Closed

fix(release): close superseded Scoop-bump PRs before opening a new one#302
marianogappa wants to merge 1 commit into
mainfrom
fix/scoop-close-stale-bump-prs

Conversation

@marianogappa

Copy link
Copy Markdown
Owner

Back-to-back releases can leave an older Scoop-bump PR with a stalled auto-merge; the release workflow now closes any open chore/scoop-bump-* PR before opening the new one, preventing a stale bump from later regressing the manifest.

@github-actions

Copy link
Copy Markdown
Contributor

🔻 Coverage below the badge

make coverage reports 80.7% (hand-written code; generated code excluded), below the README badge of 81%.

Either add tests, or update the badge: scripts/update-readme-coverage.sh 80.7.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ingestion benchmark (base → PR)

Corpus: internal/patterns/markers/testdata/replays · 3 samples · GitHub-hosted 2-core runner. Informational only — runner variance is ±10–20%, so a small delta is noise.

goos: linux
goarch: amd64
pkg: github.com/marianogappa/screpdb/internal/storage
cpu: AMD EPYC 7763 64-Core Processor                
                        │ bench-base.txt │       bench-current.txt        │
                        │     sec/op     │   sec/op     vs base           │
SQLiteIngestionCorpus-4      34.97 ± ∞ ¹   35.13 ± ∞ ¹  ~ (p=0.700 n=3) ²
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

                        │ bench-base.txt │       bench-current.txt        │
                        │     s/cmds     │   s/cmds     vs base           │
SQLiteIngestionCorpus-4      27.81 ± ∞ ¹   27.95 ± ∞ ¹  ~ (p=0.700 n=3) ²
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

                        │ bench-base.txt │        bench-current.txt        │
                        │    s/commit    │   s/commit    vs base           │
SQLiteIngestionCorpus-4     349.3m ± ∞ ¹   357.2m ± ∞ ¹  ~ (p=0.200 n=3) ²
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

                        │ bench-base.txt │        bench-current.txt        │
                        │    s/events    │   s/events    vs base           │
SQLiteIngestionCorpus-4     104.7m ± ∞ ¹   107.8m ± ∞ ¹  ~ (p=0.700 n=3) ²
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

                        │   bench-base.txt    │           bench-current.txt            │
                        │ s/ingest_166replays │ s/ingest_166replays  vs base           │
SQLiteIngestionCorpus-4           34.93 ± ∞ ¹           35.10 ± ∞ ¹  ~ (p=0.700 n=3) ²
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

                        │ bench-base.txt │       bench-current.txt        │
                        │    s/parse     │   s/parse    vs base           │
SQLiteIngestionCorpus-4      4.858 ± ∞ ¹   4.855 ± ∞ ¹  ~ (p=0.700 n=3) ²
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

                        │ bench-base.txt │        bench-current.txt        │
                        │   s/patterns   │  s/patterns   vs base           │
SQLiteIngestionCorpus-4     88.77m ± ∞ ¹   90.08m ± ∞ ¹  ~ (p=0.700 n=3) ²
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

                        │ bench-base.txt │        bench-current.txt        │
                        │   s/players    │  s/players    vs base           │
SQLiteIngestionCorpus-4     49.04m ± ∞ ¹   49.53m ± ∞ ¹  ~ (p=1.000 n=3) ²
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

                        │ bench-base.txt │        bench-current.txt        │
                        │    s/replay    │   s/replay    vs base           │
SQLiteIngestionCorpus-4     210.4m ± ∞ ¹   211.4m ± ∞ ¹  ~ (p=0.600 n=3) ²
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

                        │ bench-base.txt │        bench-current.txt        │
                        │  s/replay_ins  │ s/replay_ins  vs base           │
SQLiteIngestionCorpus-4     21.47m ± ∞ ¹   21.53m ± ∞ ¹  ~ (p=0.500 n=3) ²
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

                        │ bench-base.txt │        bench-current.txt         │
                        │      B/op      │     B/op       vs base           │
SQLiteIngestionCorpus-4    2.531Gi ± ∞ ¹   2.531Gi ± ∞ ¹  ~ (p=0.700 n=3) ²
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

                        │ bench-base.txt │        bench-current.txt        │
                        │   allocs/op    │  allocs/op    vs base           │
SQLiteIngestionCorpus-4     22.33M ± ∞ ¹   22.33M ± ∞ ¹  ~ (p=1.000 n=3) ²
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

@marianogappa
marianogappa deleted the fix/scoop-close-stale-bump-prs branch July 11, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant