database config - encrypt password by default (#549)#551
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the default database authentication mode to use saved encrypted passwords by modifying the DatabaseAuthenticationMode constructor and the initial selection in the DatabaseRegistrationDialog. Feedback was provided suggesting the use of symbolic constants instead of hardcoded indices for UI selections to improve code robustness and maintainability.
| button_browse->SetSize(wh, wh); | ||
|
|
||
| choice_authentication->SetSelection(0); | ||
| choice_authentication->SetSelection(1); |
There was a problem hiding this comment.
Hardcoding the selection index to 1 makes the dialog less flexible if the order of authentication choices changes in the future. Consider using a symbolic constant or a more robust way to select the default authentication mode.
There was a problem hiding this comment.
Fixed by using the DatabaseAuthenticationMode::UseSavedEncryptedPwd symbolic constant instead of a hardcoded index.
1 participant
This PR addresses issue #549 by making encrypted passwords the default choice when registering or creating a database.
Changes:
DatabaseAuthenticationModedefault toUseSavedEncryptedPwd.DatabaseRegistrationDialogto default to the "Use saved user name and encrypted password" option (index 1).This ensures that if a user chooses to save their password, it will be encrypted by default using the Master Password feature, rather than being stored in plain text in the
fr_databases.conffile.