Fix theme download and update repository structure - #14
Merged
Conversation
markheydon
added
the
story
Contributor
There was a problem hiding this comment.
Pull request overview
This PR rebrands the template's expected repository naming convention from a trailing -src suffix to a trailing -dev suffix, and tries to address the "ZIP-of-ZIP" download experience by changing the actions/upload-artifact configuration and additionally attaching the built ZIP as a release asset. Documentation (README, RUNBOOK, rebrand prompt, SECURITY) is updated to reflect the new convention. A new dev container feature copilot-likes is also added.
Changes:
- Switch slug-derivation suffix from
-srcto-devin workflow, docs, and prompt; require explicitTHEME_SLUGif repo doesn't end with-dev. - Bump
actions/upload-artifactto v7 witharchive: false, grantcontents: write, and upload ZIP as a release asset on release events. - Add
copilot-likesdevcontainer feature and corresponding lock entry.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/theme-distribution.yml | Enforce -dev suffix, change artifact upload, add release-asset upload |
| README.md | Document new -dev naming and ZIP/release behavior |
| RUNBOOK.md | Updated test expectations and troubleshooting for new ZIP behavior |
| SECURITY.md | Updates vulnerability reporting URL to -dev repo name |
| .github/prompts/theme-rebrand.prompt.md | Adds repository naming requirement section |
| .devcontainer/devcontainer.json | Adds copilot-likes devcontainer feature |
| .devcontainer/devcontainer-lock.json | Lockfile entry for the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed issues with nested zip files in theme downloads and updated the repository naming convention to require a
-devsuffix.