Drop redundant null-response guard from Sample.Cli (6.0.0 follow-up)#20
Merged
Conversation
InvokeAsync returns a non-nullable response in 6.0.0, so the `if (report is null) return 1` guard is dead. Remove it; the error path keeps exit code 2. Walkthrough wiki page updated to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19 (the 6.0.0 non-nullable
Response/InvokeAsyncchange).InvokeAsyncnow returns a non-nullable response, so theif (report is null) return 1guard inSample.Cli/Program.csis dead code. Removed it; the error path keeps exit code 2.The wiki Sample-CLI walkthrough and exit-code table are updated to match (separate wiki commit).
Verification
dotnet build/dotnet format --severity info --verify-no-changes— cleandotnet test— 179 passed, 0 failed🤖 Generated with Claude Code