Skip to content

Compute unit-count products in fmatch's feasibility check as doubles #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nullsatz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Compute unit-count products in fmatch's feasibility check as doubles #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions R/fmatch.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,14 @@ fmatch <- function(distance,
stop('Cannot choose "(_End_)" as unit name')

## Bypass solver if problem is recognizably infeasible
## The products below are counts of units, which on large problems can
## exceed .Machine$integer.max (e.g. 1.5e4 treated x 3.7e5 controls).
## Integer overflow would make them NA and the `if` would then stop with
## "missing value where TRUE/FALSE needed" instead of reporting the
## infeasibility, so compute them in double precision.
if ( (mxr >1 & nt/mxr > n.mc) | #max.row.units too low
(mxr==1L & nt * mnc > n.mc) | #min.col.units too high
(nt * mxc < n.mc)) { #max.col.units too low
(mxr==1L & as.numeric(nt) * mnc > n.mc) | #min.col.units too high
(as.numeric(nt) * mxc < n.mc)) { #max.col.units too low

out <- as.data.frame(distance, row.names = NULL)
out$solution <- rep(-1L, narcs)
Expand Down
Loading