feat(schema): add exercise_log and exercise_set entity types for per-set tracking#310
Open
castor-agent wants to merge 7 commits into
Open
feat(schema): add exercise_log and exercise_set entity types for per-set tracking#310castor-agent wants to merge 7 commits into
castor-agent wants to merge 7 commits into
Conversation
Adds a [GITHUB ENTITY EXTRACTION] section to MCP instructions and a new docs/subsystems/github_entities.md documenting how to extract and store GitHub issue, PR, org, and project entities when encountered in email records. Also adds a pull_request entity type schema to ENTITY_SCHEMAS. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds an explicit [STORE-FIRST PROTOCOL] section to the MCP interaction instructions fenced block in docs/developer/mcp/instructions.md. The new section makes the external-write store-first rule binding and unambiguous: agents MUST store intent as a Neotoma entity before executing any external write action (email send, GitHub issue creation, calendar event booking, Slack post, webhook trigger, etc.), update the entity status after the action completes or fails, and never skip the store step regardless of how trivial the action appears. The section includes a three-step checklist, entity-type mapping for common external actions, on-failure behavior, and explicit FORBIDDEN rules. The existing "External tool store-first" line in [COMMUNICATION & DISPLAY] is updated to cross-reference the new section. The design-rationale section label list is updated to include the new section. Also adds a Store-first protocol section to docs/foundation/what_to_store.md explaining the three-step sequence for users and operators. Fixes #174 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Implements issue #169. - --project-local: stores init config in .neotoma/config.json in the current directory (project-scoped) instead of ~/.config/neotoma/config.json (user-scoped). Project-local config takes precedence over user-level config when readEffectiveConfig() is used. - --safe: dry-run mode that reports what init would do (create directories, write config, initialize databases) without making any changes. Outputs a human-readable checklist in pretty mode or a JSON object with dry_run=true and planned_actions[] when --json is set. Exit 0 if all planned actions would succeed. Also adds: - writeProjectLocalConfig() and projectLocalConfigPath() helpers in config.ts - readEffectiveConfig() that merges project-local over user-level config - Tests in tests/cli/cli_init_flags.test.ts covering both flags - cli_reference.md documentation with examples and runtime override tables - Updated automated test catalog Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rting instructions Fixes #160 Changes `issues.reporting_mode` default from `consent` to `proactive` so agents file issues immediately when a reportable condition is detected, without asking for permission. Removes the "mode discovery" prompt that asked the user once to configure their preference on first encounter. Key changes in docs/developer/mcp/instructions.md [ISSUE REPORTING] section: - Default mode is now `proactive` (was `consent`) - Removed mode discovery flow (no longer asks "what reporting mode do you prefer?") - Added standing-consent statement: Neotoma installation constitutes consent - Added explicit opt-out path: preference entity with `auto_file_issues: false` - FORBIDDEN clause explicitly names the consent-prompt patterns agents must not use Also updates [QA REFLECTION] QA-driven issue filing and Issue reporting lines to reflect `proactive` as default and reference the `auto_file_issues` preference opt-out. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…158) Adds reference_fields, linked_issues field, and documentation to the pull_request schema bootstrap declaration. Specifically: - src/services/schema_definitions.ts: add linked_issues field (type: string) and reference_fields declaring author→contact, repo→github_repo, and linked_issues→issue with REFERS_TO edges. All three reference fields reference declared schema fields. Bump schema_version to 1.1. - docs/subsystems/record_types.md: add pull_request to the Productivity Schema Family table and add a full Pull Request section under 4.2 Productivity Types documenting required/optional fields, identity rule, aliases, reference fields, and schema registration location. - tests/unit/pull_request_schema.test.ts: 20 unit tests covering ENTITY_SCHEMAS registration, canonical_name_fields (number+repo composite and url fallback), temporal_fields (created_at, merged_at, closed_at with event types), reference_fields entries (author, repo, linked_issues), field declarations, merge policies, and no-dangling- reference-field constraint. - docs/testing/automated_test_catalog.md: regenerated to include the new test file. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-set entity (#246) Implements the per-set entity model for exercise tracking: each set is stored as an `exercise_set` entity with a PART_OF relationship to the parent `exercise_log` session container. - Updates `exercise_log` (schema v2.0) to be a workout session container (date, workout_type, duration_minutes, notes) with canonical identity on [date, workout_type] and a temporal_fields declaration for timeline events. - Adds `exercise_set` entity type for atomic per-set data (exercise_name, set_number, reps, weight_lbs, weight_kg, duration_seconds, distance_meters) with canonical identity on [exercise_name, set_number, date]. - Documents the PART_OF relationship model and store workflow in docs/subsystems/exercise_tracking.md. - Adds [EXERCISE TRACKING] section to MCP instructions fenced block. - Adds 24 unit tests covering both entity types (identity rules, field types, merge policies, metadata). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Claude finished @castor-agent's task —— View job PR Review in progress
|
Collaborator
Author
|
@claude review |
|
Claude finished @castor-agent's task —— View job PR Review in progress
|
Missing commit dcf6235 (use git ls-files in test catalog generator). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
/create_pr skill auditAutomated audit against the Verdict: does not fully meet standards. Gaps below; recommended changes follow each item. Findings
Recommended changesUpdate the PR description to match the skill template exactly: ## Problems
- <Concrete pain point or gap.>
## Solutions
- <Concrete change made.>
## UX improvements
- <User-visible behavior change, or `No user-visible change.`>
## Documentation
- <docs/... path(s) added or updated; parameters/outputs/examples/error modes covered.>
- <`docs/site/site_doc_manifest.yaml` entry added/updated; docs service tests pass.>
- <Or: `No functional change; no user-facing docs required.`>
## Test plan
- [ ] `npm run type-check`
- [ ] `npm test`
- [ ] `npm test -- src/services/docs` (if docs changed)
- [ ] Manual verification: <steps>
## Breaking changes
No breaking changes.
## Related
- Plan: <Neotoma plan entity_id or docs/ path>
- Issue(s): <#N>
🤖 Generated with [Claude Code](https://claude.com/claude-code)Functional surfaces detected from the diff: CLI, MCP, Schema. Per the skill, the Posted by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #246
Implements the per-set entity model for exercise tracking: each set is stored as an
exercise_setentity with a PART_OF relationship to the parentexercise_logsession entity. Adds schema declarations, documentation, and MCP instruction guidance.Summary
exercise_log(schema v2.0) from a per-set entity to a workout session container withdate,workout_type,duration_minutes,notes,locationfields and canonical identity on[date, workout_type]exercise_setentity type for atomic per-set data:exercise_name,set_number,reps,weight_lbs,weight_kg,duration_seconds,distance_meterswith canonical identity on[exercise_name, set_number, date]exercise_set PART_OF exercise_logrelationship model and full store workflow with JSON examples indocs/subsystems/exercise_tracking.md[EXERCISE TRACKING]section to MCP instructions fenced blockTest plan
npm run type-check— cleannpm run format:check— cleantests/unit/exercise_schema.test.ts— 24/24 tests passnpm run validate:test-catalog— catalog up to date🤖 Generated with Claude Code