Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
marko@5.38.36
Patch Changes
#3159
19d4b37Thanks @DylanPiercey! - Fix escaping issue for dynamic text interpolation inside<script>,<style>,<html-script>and<html-style>tags.The issue was that the escaping logic for those tags used a CASE SENSITIVE search for the closing tag which could be bypassed like so:
Note that
scriptandstylethere should never render unsanitized user defined values, regardless of wether or not the closing tag is escaped, since these are conceptually just "eval".#3159
19d4b37Thanks @DylanPiercey! - Fix escaping for<html-comment>tag.Previously this tag relied on normal xml escaping which looks for
<.This PR updates to have a special escape for
<html-comment>tags that replaces>instead.Updated dependencies [
19d4b37,19d4b37]:@marko/runtime-tags@6.0.164
Patch Changes
#3159
19d4b37Thanks @DylanPiercey! - Fix escaping issue for dynamic text interpolation inside<script>,<style>,<html-script>and<html-style>tags.The issue was that the escaping logic for those tags used a CASE SENSITIVE search for the closing tag which could be bypassed like so:
Note that
scriptandstylethere should never render unsanitized user defined values, regardless of wether or not the closing tag is escaped, since these are conceptually just "eval".#3159
19d4b37Thanks @DylanPiercey! - Fix escaping for<html-comment>tag.Previously this tag relied on normal xml escaping which looks for
<.This PR updates to have a special escape for
<html-comment>tags that replaces>instead.