Conversation
e0296f2 to
7f447e1
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a new explanation doc at /docs/explanation/class-vs-tags-api comparing the Class API and Tags API, with sections on components, event handling, refs, lifecycle, derived values, examples, and further reading. Registers the new route in the generated typed routes and page module declarations, and adds a navigation entry to the app menu. Updates documentation guidance in 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present. |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/explanation/class-vs-tags-api.md`:
- Line 131: Correct the typo in the sentence "In the Class API, running code
whens something mounts inside a loop requires a child component." by changing
"whens" to "when" so it reads "In the Class API, running code when something
mounts inside a loop requires a child component."
- Line 79: Fix the typo in the paragraph that recommends using element
references from tag variables (the sentence referencing getEl and
../reference/native-tag.md#element-references) by changing "usd" to "used" so
the sentence reads "...it can be used anywhere in the template."
- Around line 230-236: The example shows deriving num via the Marko const tag
but still renders input.num; update the output to use the derived value instead.
Replace the `${input.num}` render with the derived `num` (produced by
`<const/num=parseInt(input.num)>`) so the snippet demonstrates the derivation;
keep the Input interface and const declaration as-is and only change the output
expression to reference `num`.
- Line 1: The top-level heading "# Tags API for Class API Developers" is too
long; replace it with a concise 1–3 word H1 such as "# Tags API Guide" (or
simply "# Tags") by editing the heading line in
docs/explanation/class-vs-tags-api.md so the file starts with the shortened H1.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e75ceea0-dc44-4072-9218-0d2c659c5d6d
📒 Files selected for processing (5)
.cursorrules.marko-run/routes.d.tsdocs/explanation/class-vs-tags-api.mddocs/reference/language.mdsrc/tags/app-menu/app-menu.marko
New Doc: Tags API for Class API developers