Skip to content

Add download validation and domain reachability checks - #73

Open
EstusFlask wants to merge 1 commit into
markomijic:mainfrom
EstusFlask:pr
Open

EstusFlask wants to merge 1 commit into
markomijic:mainfrom
EstusFlask:pr

Conversation

@EstusFlask

Copy link
Copy Markdown

Summary

  • Show a green completion check on Mods and Saves when every resource is downloaded, or when every remaining missing resource has been confirmed invalid.
  • Automatically validate incomplete downloads by checking domain reachability before checking individual resource URLs.
  • Distinguish unreachable-domain failures from invalid-resource failures in the result dialogs.
  • Add a Settings > Network action that checks every unique domain referenced by Mods and Saves, including excluded domains.
  • Persist invalid URL results and invalidate the cache when the source JSON timestamp changes.

Behavior

  • Completion indicators are shown in both grid and list views; Saved Objects retain their existing behavior.
  • Entries with zero resources are considered complete.
  • Post-download validation is wired into single, asset-level, backup, and bulk download flows.
  • Any HTTP response counts as a reachable domain; only transport-level failures mark a domain unreachable.
  • Invalid URLs are persisted only after all relevant domains are reachable, avoiding false invalid results caused by network conditions.

Testing

  • flutter analyze --no-pub
  • flutter build windows --release --no-pub
  • Smoke-tested the generated Windows x64 release executable

Screenshots

Completion indicators, invalid-resource results, domain reachability results, and the new Network settings action:

codex-clipboard-a462c3c1-ac2a-492f-bb0a-70b564975088 codex-clipboard-d4b18116-f1f2-495b-8e68-0f5812465ce4 codex-clipboard-e4e4be02-2869-4419-b968-67f17b2031ed codex-clipboard-6e453cf2-e89d-4f19-ae10-70e81f16fe19 codex-clipboard-3a29a086-a1da-4510-aad6-0846e2b3361b

This adds post-download URL validation to detect invalid resources and unreachable domains, and surfaces the results in dialogs across single and bulk actions. It also persists invalid URL cache data, updates mod completion state, and exposes a settings action to check all domains referenced by Mods and Saves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant