feat: add Circuit.from_pyquil import#16
Open
huhaha120 wants to merge 1 commit into
Open
Conversation
Assisted-by: Codex
409bafe to
8130b02
Compare
Contributor
|
Thanks for the PR. I see you've made a large amount of PRs on a large number of projects in the unitaryHACK listing. The concern here would be that Codex has done all the work, and there's not been any good-faith effort to really understand the project, make thoughtful decisions, and properly test the solution in context. To help me understand if that's the case, I'd like to hear your thoughts on this, and talk a little about your experience and approach using the Marqov SDK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Circuit.from_pyquil()to import pyQuilProgramobjects into Marqov circuits.CONTRIBUTING.md: H, X, Y, Z, S, T, RX, RY, RZ, CNOT, CZ, and SWAP.pyquiloptional dependency extra and include it in theallextra.to_pyquil()/from_pyquil()round-trip.Closes #4
Tests
python3 -m py_compile marqov/circuits.py tests/test_circuits.pyuv run --python 3.12 --with ruff ruff check marqov/circuits.py tests/test_circuits.pyuv run --python 3.12 --extra dev --extra pyquil python -m pytest tests/test_circuits.py::TestFromPyquil -qgit diff --checkAI Assistance Disclosure
This contribution was AI-assisted. I used Codex as a coding assistant, reviewed the issue requirements and implementation scope, and verified the change locally with the tests listed above.