feat(benchmarks): add unified benchmark suite#18
Conversation
|
Thanks for the PR. I see you're a brand new account, making a number of PRs on projects in the unitaryHACK listing (and your Marqov submission were even before the event started!). The concern here would be that AI has done all the work, and there's not been any good-faith effort to really understand the project, make thoughtful decisions, and properly test the solution in context. To help me understand if that's the case, I'd like to hear your thoughts on this, and talk a little about your experience and approach using the Marqov SDK. |
|
Thanks for raising this directly. I understand the concern, especially given the timing and the fact that this is a new account. I did use AI assistance while working on this PR, but I do not want to represent it as a black-box "agent submitted this and I have no idea what it does." My intent was to solve the specific benchmark-harness request in #5 in the smallest way that matched the project's existing executor interface and the Section 5 benchmark format in My understanding of the Marqov SDK in this area is:
The main design choice I made was to keep the first version deliberately narrow: local executor support through a simple factory, repeated For testing, I added focused tests around the deterministic parts: top-outcome ordering, table formatting, result-to-row conversion, one-row-per-case execution, and skip/log behavior. Ruff passes for the touched files: /tmp/marqov-sdk-venv/bin/python -m ruff check benchmarks/suite.py tests/test_benchmark_suite.pyI also want to be clear about what I have not fully verified. A full local install/test run is currently blocked on this machine by the Braket/default-simulator dependency chain: So I should not overclaim that this has had a clean full-project test pass in my local environment. On the unitaryHACK timing point: I was looking through listed repos before the event window and opened this before realizing that could create exactly this kind of trust issue. If that makes this inappropriate for event/bounty consideration, I understand. I am happy for this to be reviewed purely as a normal contribution, or to withdraw it if that is the better outcome for the project. If you think the PR is directionally useful, I am happy to tighten it based on how you expect Marqov benchmarks to be used. For example, I can:
I am also happy to walk through any part of the implementation or revise it based on your feedback. |
Closes #5.
Summary
benchmarks/suite.pywith Bell, 3-qubit GHZ, and deterministic random depth-5 circuits--executor local --shots Nand repeated--executorflags for comparison runsVerification
/tmp/marqov-sdk-venv/bin/python -m ruff check benchmarks/suite.py tests/test_benchmark_suite.py7 passedusing explicit lightweight stubs for optional cloud/circuit SDK importsLocal environment note
uv run --extra dev --extra all ...setup remains blocked locally becausellvmliteneedscmake, which is not installed on this machine. The failure is in Braket simulator dependency setup before the benchmark tests run.