feat(executors): add Quantinuum executor#19
Open
kpassito wants to merge 2 commits into
Open
Conversation
Assisted-by: GPT-5 Codex via Codex
Assisted-by: GPT-5 Codex via Codex
Contributor
|
Thanks for the PR. I see you're making a number of PRs on projects in the unitaryHACK listing. The concern here would be that AI has done all the work, and there's not been any good-faith effort to really understand the project, make thoughtful decisions, and properly test the solution in context. To help me understand if that's the case, I'd like to hear your thoughts on this, and talk a little about your experience and approach using the Marqov SDK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
QuantinuumExecutorandQuantinuumExecutorConfigusingpytket-quantinuum, registered throughExecutorFactorywith provider string"Quantinuum".This also includes the
Circuit.to_pytket()conversion path needed by the executor because the prerequisite converter issue has not merged yet.Closes #6
Type of change
Testing
pytest tests/ -vand tests passTest details:
Focused local checks:
.venv/bin/python -m pytest tests/test_executors.py::TestQuantinuumExecutorConfig tests/test_executors.py::TestQuantinuumExecutor tests/test_executors.py::TestQuantinuumExecutorFactory -q- 9 passed.venv/bin/python -m pytest tests/test_circuits.py::TestToPytket -q- 3 passed.venv/bin/python -m ruff check marqov/executors/quantinuum.py marqov/executors/factory.py marqov/executors/__init__.py marqov/circuits.py tests/test_executors.py tests/test_circuits.py- passedThe executor tests use a mocked
pytket-quantinuumbackend, matching the issue's acceptance criteria. I did not run a hardware smoke test.Checklist
CONTRIBUTING.md §1(if adding a circuit converter)For new executors only:
ExecutorFactoryperCONTRIBUTING.md §3get_status()returns device-level availability ("online"/"offline"/"maintenance"), not job-level statusAI disclosure
Codex assisted with implementation, test planning, and local validation for this contribution. The commit messages include the disclosure footer:
Assisted-by: GPT-5 Codex via Codex