Skip to content

feat(circuits): add Circuit.from_pyquil import#20

Open
jesusblls wants to merge 1 commit into
marqov-dev:mainfrom
jesusblls:codex/from-pyquil-import
Open

feat(circuits): add Circuit.from_pyquil import#20
jesusblls wants to merge 1 commit into
marqov-dev:mainfrom
jesusblls:codex/from-pyquil-import

Conversation

@jesusblls

Copy link
Copy Markdown

Closes #4.

Summary

  • add Circuit.from_pyquil() for importing concrete pyquil.Program instances
  • map the canonical Marqov gate set including rotations, CNOT/CZ, and native SWAP
  • reject unsupported Quil-native gates with NotImplementedError
  • add an optional pyquil extra and include it in all

Tests

  • .venv312/bin/python -m pytest tests/test_circuits.py::TestFromPyQuil -q -> 6 passed, 18 warnings
  • .venv312/bin/python -m ruff check marqov/circuits.py tests/test_circuits.py pyproject.toml -> All checks passed
  • .venv/bin/python -m py_compile marqov/circuits.py tests/test_circuits.py -> passed
  • git diff --check -> clean

AI disclosure: this PR was implemented with assistance from OpenAI Codex.

@ddri

ddri commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR. I see your account is set up to focus on bounties. Have you registered for the unitaryHACK event? And did you follow the instructions at the bottom of the GitHub Issue?

The concern here would be that AI has done all the work, and there's not been any good-faith effort to really understand the project, make thoughtful decisions, and properly test the solution in context.

To help me understand if that's the case, I'd like to hear your thoughts on this, and talk a little about your experience and approach using the Marqov SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(circuits): add Circuit.from_pyquil() import

2 participants