Skip to content

feature: add Circuit.to_pytket() and QuantinuumExecutor (Closes #3 and #6)#31

Open
sim-eng-ii wants to merge 19 commits into
marqov-dev:mainfrom
sim-eng-ii:feature/to_pyket
Open

feature: add Circuit.to_pytket() and QuantinuumExecutor (Closes #3 and #6)#31
sim-eng-ii wants to merge 19 commits into
marqov-dev:mainfrom
sim-eng-ii:feature/to_pyket

Conversation

@sim-eng-ii

@sim-eng-ii sim-eng-ii commented Jun 6, 2026

Copy link
Copy Markdown

Summary

This PR addresses issues #3 and #6

The method to_pyket() is introduced in marqov\circuits.py and allows for Marqov circuits to flow into the entire pytket ecosystem. The method was added alongside to_qiskit(), to_braket(), to_pyquil() methods

The implementation was written by looking at the structure of from_qiskit(), though in reverse.
Finally, pytket was added in pyproject.toml

    "pytket>=2.0.0",
    "pytket-qiskit>=0.50.0",
    "qiskit>=1.0.0",
]

Regarding QuantinuumExecutor, I have added the QuantumExecutorConfig and QuantumExecutor classes under quantinuum.py

Inegrated _create_quantinuum_executor() in factory.py

Type of change

Circuit format converter and executor

Testing

  • [x ] I ran pytest tests/ -v and tests pass
  • [ x] For circuit converters: roundtrip test passes with known-correct reference circuit

Test details:

pytest tests/test_circuits.py::TestToPytket::test_to_pytket_bell_state -v
The test has two assertions using bell_state()

Checklist

  • [ x] No hardcoded credentials or API keys
  • [x ] Handles the canonical gate set from CONTRIBUTING.md §1 (if adding a circuit converter)

Note: used cursor to install libraries,

@sim-eng-ii sim-eng-ii closed this Jun 6, 2026
@sim-eng-ii sim-eng-ii reopened this Jun 6, 2026
@sim-eng-ii

Copy link
Copy Markdown
Author

@ddri Hello, feel free to let me know if this is okay or if you need any changes. I will try fixing other issues as well!

@sim-eng-ii sim-eng-ii changed the title feature: add Circuit.to_pytket() feature: add Circuit.to_pytket() and QuantinuumExecutor Jun 7, 2026
@sim-eng-ii

Copy link
Copy Markdown
Author

@ddri, I am working on #6 and pushing changes to this branch via subbranch so they are both addressed. Thank you.

@sim-eng-ii sim-eng-ii changed the title feature: add Circuit.to_pytket() and QuantinuumExecutor feature: add Circuit.to_pytket() and QuantinuumExecutor (Closes #3 and #6) Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant