Skip to content

Feature/get article cache#147

Merged
bernomone merged 4 commits into
mainfrom
feature/get-article-cache
Jul 4, 2025
Merged

Feature/get article cache#147
bernomone merged 4 commits into
mainfrom
feature/get-article-cache

Conversation

@bernomone
Copy link
Copy Markdown
Collaborator

Add cache to get_article, thanks Claude Code!

@bernomone bernomone requested a review from martinapugliese July 1, 2025 16:00
@bernomone bernomone marked this pull request as ready for review July 2, 2025 19:46
Copy link
Copy Markdown
Owner

@martinapugliese martinapugliese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sarà la feature più testata che abbiamo 😅..ma la cache come si cancella?

Comment thread README.md

The agent reads the paper via pulling the whole text from arXiv, there isn't an API endpoint giving whole text so this is done via the site. This feature is meant to be used lightly, that is, not reading too many papers at short turnarounds, because this would violates arXiv's terms of use.

To minimize API load, Askademic includes a caching system that saves previously fetched papers for 7 days. This helps reduce the number of requests to arXiv and improves response times for papers you've already accessed.
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfetto! Berna se non ti spiace cancelli un rimasuglio di prima qui, vedi sopra dove dice "will might come later", cancella magari tutta la frase tanto li abbiamo messi altri llm

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fatto

Comment thread src/askademic/tools.py
@@ -1,9 +1,12 @@
import hashlib
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hashlib è built-in giusto, non va messa nel pyprog?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sì tutto bultin

@bernomone
Copy link
Copy Markdown
Collaborator Author

Cancella il paper vecchio nelle linee 257-260, l'aveva implementato in realtà!

@bernomone bernomone merged commit 8a12fb6 into main Jul 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants