Open
Conversation
…0 for now since it isnt used. Remove some annoying logging. Clean up some files.
…he now unnecessary flight modules. Converted everything to f64." This reverts commit b4c5a63.
Owner
|
Is it correctly holding position, but just noisy? |
Collaborator
Author
|
Nope. Moving randomly.
…On Tue, Jan 16, 2018 at 10:15 AM Martin Deegan ***@***.***> wrote:
Is it correctly holding position, but just noisy?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABOrXPp5Le5aSP5j8Tr69WlTxl9QyuvFks5tLOb3gaJpZM4RfaN->
.
|
Collaborator
Author
|
Actually it looks fine I think: It starts on the opposite side then converges over to the correct side... |
Owner
|
Update this when you have correctly calibrated the sensors. |
martindeegan
requested changes
Jan 19, 2018
Owner
martindeegan
left a comment
martindeegan
left a comment
There was a problem hiding this comment.
Before we add this, it might be a good idea to also implement the software PWM struct as well as making it modular.
Owner
|
This did fix the Kalman filter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the problematic "Removed som random matlab generated files..." commit but it doesn't seem to help with the filter. Looks weirdly noisy to me. We can remove this revert commit from the pull request if we don't think that was actually the problematic commit.
Add support for my drone hardware.